58 task write trails drawing feature functions path optimality#93
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 98.49% 98.51% +0.01%
==========================================
Files 18 18
Lines 998 1009 +11
==========================================
+ Hits 983 994 +11
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also when reviewing keep in mind that this metric is calculated per segment, and is saved to class LineSegment. Average will be returned in final report. |
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Some small stylistic changes
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
LGTM
See minor comments about the specific values in tests
| start = models.CircleTarget(order=1, label="1", center_x=0, center_y=0, radius=1) | ||
| end = models.CircleTarget(order=2, label="2", center_x=10, center_y=0, radius=1) | ||
| expected_optimal_distance = 10 - 1 - 1 | ||
| expected_path_optimality = expected_optimal_distance / 8 |
There was a problem hiding this comment.
Can you assing a var for the value 8 here? I assume it would be the same var/value used in models.LineSegment.distance below right?
cgmaiorano
deleted the
58-task-write-trails-drawing-feature-functions-path_optimality
branch
2 participants
The path_optimality function will calculate the ratio between the optimal path distance and actual path distance. This function relies on predetermined circle locations of the presented stimulus.